Feature/monitoring remote machines wo Genv installed #55
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Supporting '--query-gpu' and '--query-compute-apps' generically * Not relying on genv.utils Python package to support machines without Genv installed - Made more parameters customizable using environment variables
* Holds information about the system - Genv installation status - Device statuses
* Supporting non-Genv shell commands - Minor cosmetics
At the moment, code was duplicated for the sake of time effectiveness. We will need to come up with a design that would allow sharing the logic for both local and over-SSH executions.
Implemented metrics: - genv_device_utilization - genv_device_memory_used_bytes Added metrics: - genv_is_installed - genv_device_temperature - genv_device_memory_total_bytes Refactor: * Moved logic from Metric to Collection * Using local collection logic from remote collection
razrotenberg
force-pushed
the
feature/monitoring-remote-machines-wo-genv-installed
branch
from
bc10c27
to
c107f1b
Compare
* Using Docker instead of virtual environment
razrotenberg
force-pushed
the
feature/monitoring-remote-machines-wo-genv-installed
branch
2 times, most recently
from
78d2646
to
1e89440
Compare
razrotenberg
force-pushed
the
feature/monitoring-remote-machines-wo-genv-installed
branch
from
1e89440
to
a629c19
Compare
razrotenberg
force-pushed
the
feature/monitoring-remote-machines-wo-genv-installed
branch
from
4e0d305
to
4102923
Compare
- Added argument -l/--username to "genv remote" - Also supporting syntax "username@hostname"
razrotenberg
deleted the
feature/monitoring-remote-machines-wo-genv-installed
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.