Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove callable param from folder method #1101

Merged
merged 1 commit into from
Aug 4, 2024

Conversation

jlewitt1
Copy link
Collaborator

@jlewitt1 jlewitt1 commented Aug 2, 2024

No description provided.

Copy link
Collaborator Author

jlewitt1 commented Aug 2, 2024

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @jlewitt1 and the rest of your teammates on Graphite Graphite

@jlewitt1 jlewitt1 force-pushed the catch-callable-param-openapi-spc branch 2 times, most recently from 8a67076 to 15f3796 Compare August 4, 2024 06:21
@jlewitt1 jlewitt1 force-pushed the catch-callable-param-openapi-spc branch from 15f3796 to 18383cb Compare August 4, 2024 06:56
@jlewitt1 jlewitt1 changed the title [WIP] surface callable params in openapi spec [WIP] remove callable param from folder method Aug 4, 2024
@jlewitt1 jlewitt1 changed the title [WIP] remove callable param from folder method remove callable param from folder method Aug 4, 2024
@jlewitt1 jlewitt1 marked this pull request as ready for review August 4, 2024 14:48
@jlewitt1 jlewitt1 merged commit 17500c8 into main Aug 4, 2024
12 of 13 checks passed
@jlewitt1 jlewitt1 deleted the catch-callable-param-openapi-spc branch August 4, 2024 15:16
@dongreenberg
Copy link
Contributor

I think we should revert this, I really don't want to have Callable params to built-in modules if we can avoid it. It's basically building an assumption of pickling into the http call to the module which we don't want to do.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants