Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cache computation of Module's signature. #665

Merged
merged 1 commit into from
Mar 27, 2024
Merged

Conversation

rohinb2
Copy link
Contributor

@rohinb2 rohinb2 commented Mar 26, 2024

Now that we're caching this, we can get rid of the rich variable that we were previously using to speed stuff up. Plus if there's code that calls it with rich=False, it would be cached, which isn't what we want.

Copy link
Contributor Author

rohinb2 commented Mar 26, 2024

Copy link
Contributor Author

rohinb2 commented Mar 27, 2024

Merge activity

  • Mar 27, 2:04 PM EDT: @rohinb2 started a stack merge that includes this pull request via Graphite.
  • Mar 27, 2:07 PM EDT: Graphite rebased this pull request as part of a merge.
  • Mar 27, 2:08 PM EDT: @rohinb2 merged this pull request with Graphite.

@rohinb2 rohinb2 changed the base branch from rohin/module-dir-cache to main March 27, 2024 18:05
@rohinb2 rohinb2 merged commit 4ed4a3a into main Mar 27, 2024
5 of 11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant