Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Properly raise exception when Module was unable to be loaded from pointers. #747

Merged
merged 1 commit into from
Apr 23, 2024

Conversation

rohinb2
Copy link
Contributor

@rohinb2 rohinb2 commented Apr 23, 2024

pointers.

Copy link
Contributor Author

rohinb2 commented Apr 23, 2024

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @rohinb2 and the rest of your teammates on Graphite Graphite

@rohinb2 rohinb2 mentioned this pull request Apr 23, 2024
Copy link

sentry-io bot commented Apr 23, 2024

🔍 Existing Issues For Review

Your pull request is modifying functions with the following pre-existing issues:

📄 File: runhouse/resources/module.py

Function Unhandled Issue
to ValueError: Error installing runhouse on cluster node <69.30.85.17> ...
Event Count: 4
to ValueError: Error installing runhouse on cluster node <213.173.102.4> ...
Event Count: 2
to ValueError: Error installing runhouse on cluster node <91.199.227.82> ...
Event Count: 1
to AttributeError: 'str' object has no attribute 'check_server' main...
Event Count: 1
to ValueError: Error installing runhouse on cluster node <194.68.245.168> ...
Event Count: 1

Did you find this useful? React with a 👍 or 👎

@rohinb2 rohinb2 marked this pull request as ready for review April 23, 2024 16:35
@rohinb2 rohinb2 merged commit 106e257 into main Apr 23, 2024
9 of 11 checks passed
@jlewitt1 jlewitt1 deleted the rohin/module-load-bug-fix branch April 24, 2024 21:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant