Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add default env docstrings #760

Merged
merged 1 commit into from
May 1, 2024
Merged

Add default env docstrings #760

merged 1 commit into from
May 1, 2024

Conversation

carolineechen
Copy link
Collaborator

No description provided.

Copy link
Collaborator Author

carolineechen commented Apr 30, 2024

Copy link

sentry-io bot commented Apr 30, 2024

🔍 Existing Issues For Review

Your pull request is modifying functions with the following pre-existing issues:

📄 File: runhouse/resources/hardware/cluster_factory.py

Function Unhandled Issue
ondemand_cluster NameError: name 'sky' is not defined main in ...
Event Count: 6
sagemaker_cluster RuntimeError: SageMaker SDK requires AWS CLI v2. You may also need to run pip uninstall awscli to ensure the ... ...
Event Count: 2
sagemaker_cluster NameError: name 'sagemaker' is not defined __main...
Event Count: 1

Did you find this useful? React with a 👍 or 👎

@carolineechen carolineechen marked this pull request as ready for review April 30, 2024 20:02
Copy link

graphite-app bot commented Apr 30, 2024

Ill Allow It GIF (Added via Giphy)

Copy link

graphite-app bot commented Apr 30, 2024

Graphite Automations

"rohin" took an action on this PR • (04/30/24)

1 gif was posted to this PR based on Rohin Bhasin's automation.

@carolineechen carolineechen merged commit d07e600 into main May 1, 2024
11 checks passed
@carolineechen carolineechen deleted the cc/default-env-docstring branch May 1, 2024 05:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants