Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update den auth default to None in cluster factory #784

Merged
merged 1 commit into from
May 7, 2024

Conversation

carolineechen
Copy link
Collaborator

default value False for den auth in cluster factory caused alt_options to be set, so calling cluster("name") would sometimes result in a config mismatch and fail to reconstruct the resource correctly. set it to none in factory and correspondingly update to False in cluster init instead.

Copy link

sentry-io bot commented May 7, 2024

🔍 Existing Issues For Review

Your pull request is modifying functions with the following pre-existing issues:

📄 File: runhouse/resources/hardware/cluster_factory.py

Function Unhandled Issue
ondemand_cluster AttributeError: module 'sky' has no attribute 'global_user_state' __m...
Event Count: 4
ondemand_cluster NameError: name 'sky' is not defined main in ...
Event Count: 3

Did you find this useful? React with a 👍 or 👎

Copy link
Collaborator Author

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @carolineechen and the rest of your teammates on Graphite Graphite

@carolineechen carolineechen marked this pull request as ready for review May 7, 2024 14:55
@carolineechen carolineechen merged commit b3183bb into main May 7, 2024
7 of 11 checks passed
@carolineechen carolineechen deleted the cc/cluster-default branch May 7, 2024 16:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant