Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update error handling when serializing data #807

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

jlewitt1
Copy link
Collaborator

@jlewitt1 jlewitt1 commented May 20, 2024

Looks like an edge case, but seeing this when trying to call an HTTP URL of a function on a cluster:

  File "/opt/conda/lib/python3.10/site-packages/runhouse/servers/http/http_server.py", line 99, in wrapper
    raise e
  File "/opt/conda/lib/python3.10/site-packages/runhouse/servers/http/http_server.py", line 95, in wrapper
    res = await func(*args, **kwargs)
  File "/opt/conda/lib/python3.10/site-packages/runhouse/servers/http/http_server.py", line 492, in get_call
    "error": serialize_data(e, serialization),
  File "/opt/conda/lib/python3.10/site-packages/runhouse/servers/http/http_utils.py", line 121, in serialize_data
    data["error"] = str(data["error"])
TypeError: 'TypeError' object is not subscriptable```

Copy link

sentry-io bot commented May 20, 2024

🔍 Existing Issues For Review

Your pull request is modifying functions with the following pre-existing issues:

📄 File: runhouse/servers/http/http_utils.py

Function Unhandled Issue
serialize_data TypeError: 'TypeError' object is not subscriptable /{key}/{method_nam...
Event Count: 3
serialize_data ValueError: Invalid serialization type "None /{ke...
Event Count: 1

Did you find this useful? React with a 👍 or 👎

Copy link
Collaborator Author

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @jlewitt1 and the rest of your teammates on Graphite Graphite

@jlewitt1 jlewitt1 requested a review from rohinb2 May 20, 2024 10:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant