Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(metadataFiltering): prefilters not being passed to vector query #412

Merged
merged 2 commits into from
Jan 22, 2024
Merged

fix(metadataFiltering): prefilters not being passed to vector query #412

merged 2 commits into from
Jan 22, 2024

Conversation

EmanuelCampos
Copy link
Contributor

No description provided.

@vercel Vercel
Copy link

vercel bot commented Jan 21, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
llama-index-ts-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 21, 2024 0:15am

@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Jan 21, 2024

⚠️ No Changeset found

Latest commit: 48f954e

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@EmanuelCampos EmanuelCampos self-assigned this Jan 21, 2024
@EmanuelCampos EmanuelCampos changed the title fix(metadataFiltering): PreFilters not being passed to vector query fix(metadataFiltering): prefilters not being passed to vector query Jan 21, 2024
marcusschiesser
marcusschiesser reviewed Jan 22, 2024
View reviewed changes
Copy link
Collaborator

@marcusschiesser marcusschiesser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@EmanuelCampos LGTM - do you see any breaking changes, e.g. with using other VectorDBs?

@EmanuelCampos
Copy link
Contributor Author

@marcusschiesser Yes! there's no breaking changes, before that wasn't working

@marcusschiesser marcusschiesser merged commit c3e3b59 into run-llama:main Jan 22, 2024
5 checks passed
@yisding
Copy link
Contributor

yisding commented Jan 22, 2024

Thanks for fixing this bug @EmanuelCampos !

EmanuelCampos added a commit to EmanuelCampos/LlamaIndexTS that referenced this pull request Jan 23, 2024
@EmanuelCampos @yisding
@owencraston @himself65 @stmtk1 @leehuwuj
Feat/docs (#1)
534eda6 
* new prettier version

* run prettier format:fix

* try adding a version to pnpm

I don't think it should make a difference...

* fix: add root package name (run-llama#403)

* feat(extractors): add keyword extractor and base extractor (run-llama#404)

Co-authored-by: Alex Yang <himself65@outlook.com>

* fix(getCollection): getOrCreateCollection (run-llama#413)

* readme sample code chnaged (run-llama#414)

* add run app option (run-llama#399)

* fix(metadataFiltering): prefilters not being passed to vector query (run-llama#412)

* feat: use conditional exports (run-llama#401)

* refactor: restructure documentation

* chore: observability position

---------

Co-authored-by: yisding <yi.s.ding@gmail.com>
Co-authored-by: Owen Craston <owengc12@gmail.com>
Co-authored-by: Alex Yang <himself65@outlook.com>
Co-authored-by: Motoki saito <stmtk1@users.noreply.github.com>
Co-authored-by: Huu Le (Lee) <39040748+leehuwuj@users.noreply.github.com>
@himself65 himself65 mentioned this pull request Apr 19, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@marcusschiesser marcusschiesser marcusschiesser left review comments

Assignees

@EmanuelCampos EmanuelCampos

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@EmanuelCampos @yisding @marcusschiesser