Skip to content
This repository has been archived by the owner on Mar 1, 2024. It is now read-only.

Update base.py #839

Merged
merged 4 commits into from
Feb 2, 2024
Merged

Update base.py #839

merged 4 commits into from
Feb 2, 2024

Conversation

miezzi
Copy link
Contributor

@miezzi miezzi commented Jan 5, 2024

Description

support for configure delimiter and quotechar in paged_csv

Fixes # (issue)

Type of Change

Please delete options that are not relevant.

  • New Loader/Tool
  • Bug fix / Smaller change
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

  • Added new unit/integration tests
  • Added new notebook (that tests end-to-end)
  • I stared at the code and made sure it makes sense

Suggested Checklist:

  • I have added a library.json file if a new loader/tool was added
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • I ran make format; make lint to appease the lint gods

support for configure delimiter and quotechar in paged_csv
@anoopshrma
Copy link
Collaborator

Hi, thank you for the contribution!

All looks good except the linting. Could you take a look at that.

@anoopshrma
Copy link
Collaborator

@miezzi quick bump on this!

@anoopshrma
Copy link
Collaborator

seems like there's some minor linting errors you can fix with make lint; make format!

@anoopshrma
Copy link
Collaborator

Everything looks good now @miezzi . Merging it!!

@anoopshrma anoopshrma merged commit 4a96830 into run-llama:main Feb 2, 2024
3 checks passed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants