Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[upstage integration] set default context size #14293

Merged
merged 8 commits into from
Jun 22, 2024

Conversation

JuHyung-Son
Copy link
Contributor

@JuHyung-Son JuHyung-Son commented Jun 21, 2024

Description

Since our models are frequently added and updated, we made sure to use DEFAULT_CONTEXT_WINDOW if given an argument that is not present in the ALL_AVAILABLE model.

#14233
This should be merged first.

@dosubot dosubot bot added the size:M This PR changes 30-99 lines, ignoring generated files. label Jun 21, 2024
@nerdai
Copy link
Contributor

nerdai commented Jun 22, 2024

@JuHyung-Son #14233 has been merged. Please resolve conflicts and push up, so that we can get this PR landed as well. Thanks!

@dosubot dosubot bot added size:XS This PR changes 0-9 lines, ignoring generated files. and removed size:M This PR changes 30-99 lines, ignoring generated files. labels Jun 22, 2024
@JuHyung-Son
Copy link
Contributor Author

@nerdai Thank you, conflict resolved.

Copy link
Contributor

@nerdai nerdai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Jun 22, 2024
@nerdai nerdai enabled auto-merge (squash) June 22, 2024 12:23
@nerdai nerdai merged commit 83e0d07 into run-llama:main Jun 22, 2024
8 checks passed
@JuHyung-Son JuHyung-Son deleted the SDR-21 branch June 22, 2024 14:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
lgtm This PR has been approved by a maintainer size:XS This PR changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants