Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(test): remove redundant test job from circleci #3026

Merged
merged 2 commits into from
Jan 23, 2023
Merged

chore(test): remove redundant test job from circleci #3026

merged 2 commits into from
Jan 23, 2023

Conversation

nitrocode
Copy link
Member

@nitrocode nitrocode commented Jan 23, 2023 •
edited
Loading

what

  • rm test job from circleci
  • add make check-fmt to existing gha test job

why

  • Reduce reliance on circleci
  • make check-lint is already done by reviewdog so no need to do that in both gha and circleci. This is why make check-lint wasn't added to the PR.

tests

  • I have tested my changes by running action in this PR

references

@nitrocode nitrocode requested a review from a team as a code owner January 23, 2023 01:01
@nitrocode nitrocode enabled auto-merge (squash) January 23, 2023 02:25
@nitrocode nitrocode merged commit 97f3c78 into main Jan 23, 2023
@nitrocode nitrocode deleted the circleci-stop-fmt-lint branch January 23, 2023 02:26
@nitrocode nitrocode added this to the v0.23.0 milestone Jan 23, 2023
@nitrocode nitrocode mentioned this pull request Jan 23, 2023
Merged
1 task
@nitrocode nitrocode added the build Relating to how we build Atlantis label Jan 23, 2023
@nitrocode nitrocode mentioned this pull request Jan 24, 2023
Merged
1 task
@albertorm95 albertorm95 mentioned this pull request May 19, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jamengual jamengual jamengual approved these changes

Assignees
No one assigned
Labels
build Relating to how we build Atlantis github-actions
Projects
None yet
Milestone
v0.23.0
Development

Successfully merging this pull request may close these issues.
2 participants
@nitrocode @jamengual