Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(executable-name): Add check for misspelled comment command #3059

Merged
merged 2 commits into from
Feb 22, 2023
Merged

feat(executable-name): Add check for misspelled comment command #3059

merged 2 commits into from
Feb 22, 2023

Conversation

edbighead
Copy link
Contributor

@edbighead edbighead commented Jan 27, 2023 •
edited
Loading

what

Add spellcheck for executable name

why

Sometimes users misspell atlantis word and are waiting for their PR to be applied. Decided to go with terraform approach and use https://github.com/agext/levenshtein

tests

Added unit tests and tested on my local atlantis server:
https://github.com/bighead-io/applications/pull/5#issuecomment-1436949866

(running atlantis under my personal user here)
image

references

Closes #3069

@edbighead edbighead requested a review from a team as a code owner January 27, 2023 08:47
@github-actions github-actions bot added the go Pull requests that update Go code label Jan 27, 2023
@edbighead edbighead force-pushed the atlantis-misspell branch 2 times, most recently from dff5c42 to a1d5c24 Compare January 27, 2023 09:24
ibbadhafeez
ibbadhafeez approved these changes Jan 27, 2023
View reviewed changes
server/events/comment_parser.go Outdated Show resolved Hide resolved
@nitrocode nitrocode added waiting-on-response Waiting for a response from the user needs discussion Large change that needs review from community/maintainers labels Jan 30, 2023
@nitrocode nitrocode marked this pull request as draft January 31, 2023 14:32
@edbighead edbighead changed the title feat: Add check for misspelled atlantis command feat: Add check for misspelled executable name command Feb 20, 2023
@edbighead edbighead force-pushed the atlantis-misspell branch 4 times, most recently from 0f8ceaf to f49cb14 Compare February 20, 2023 12:52
@edbighead edbighead marked this pull request as ready for review February 20, 2023 12:58
@edbighead
Copy link
Contributor Author

hey @nitrocode, I think it's ready for review

krrrr38
krrrr38 reviewed Feb 21, 2023
View reviewed changes
server/utils/spellcheck_test.go Outdated Show resolved Hide resolved
server/utils/spellcheck.go Outdated Show resolved Hide resolved
krrrr38
krrrr38 approved these changes Feb 21, 2023
View reviewed changes
Copy link
Contributor

@krrrr38 krrrr38 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@nitrocode @krrrr38
Update server/utils/spellcheck_test.go
f4b6137 
Co-authored-by: Ken Kaizu <k.kaizu38@gmail.com>
@nitrocode nitrocode removed waiting-on-response Waiting for a response from the user needs discussion Large change that needs review from community/maintainers labels Feb 22, 2023
@nitrocode nitrocode added this to the v0.23.0 milestone Feb 22, 2023
@nitrocode nitrocode enabled auto-merge (squash) February 22, 2023 00:42
@nitrocode nitrocode changed the title feat: Add check for misspelled executable name command feat(executable-name): Add check for misspelled comment command Feb 22, 2023
@nitrocode
Copy link
Member

Thank you @edbighead for the contribution!

Thank you @krrrr38 for the extra review!

@nitrocode nitrocode merged commit 9b61288 into runatlantis:main Feb 22, 2023
@albertorm95 albertorm95 mentioned this pull request May 19, 2023
Merged
ijames-gc pushed a commit to gocardless/atlantis that referenced this pull request Feb 13, 2024
@edbighead @nitrocode
@krrrr38 @ijames-gc
feat: Add check for misspelled executable name command (runatlantis#3059
47ccc0f 
)

* feat: Add check for misspelled executable name command

* Update server/utils/spellcheck_test.go

Co-authored-by: Ken Kaizu <k.kaizu38@gmail.com>

---------

Co-authored-by: nitrocode <7775707+nitrocode@users.noreply.github.com>
Co-authored-by: Ken Kaizu <k.kaizu38@gmail.com>
ijames-gc pushed a commit to gocardless/atlantis that referenced this pull request Feb 13, 2024
@edbighead @nitrocode
@krrrr38 @ijames-gc
feat: Add check for misspelled executable name command (runatlantis#3059
c11d87b 
)

* feat: Add check for misspelled executable name command

* Update server/utils/spellcheck_test.go

Co-authored-by: Ken Kaizu <k.kaizu38@gmail.com>

---------

Co-authored-by: nitrocode <7775707+nitrocode@users.noreply.github.com>
Co-authored-by: Ken Kaizu <k.kaizu38@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@krrrr38 krrrr38 krrrr38 approved these changes

@ibbadhafeez ibbadhafeez ibbadhafeez approved these changes

@nitrocode nitrocode nitrocode approved these changes

Assignees
No one assigned
Labels
go Pull requests that update Go code
Projects
None yet
Milestone
v0.23.0
Development

Successfully merging this pull request may close these issues.

Enable spellcheck for executable name
4 participants
@edbighead @nitrocode @krrrr38 @ibbadhafeez