fix(workflow-hook): pre/post hook not sending output due to invalid key #3091
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nitrocode
reviewed
Feb 1, 2023
| @@ -70,7 +70,8 @@ func (wh DefaultPostWorkflowHookRunner) Run(ctx models.WorkflowHookCommandContex | |||
| } | |||
| } | |||
|
|
|||
| wh.OutputHandler.SendWorkflowHook(ctx, fmt.Sprintf("%s\n", string(out)), true) | |||
| wh.OutputHandler.SendWorkflowHook(ctx, string(out), false) | |||
There was a problem hiding this comment.
Thanks for the contribution and fix @Fabianoshz. Could you please add the test section to the pr body to describe how this was tested e2e for post and pre workflpws?
Oh and could you verify that this works with automerge and no automerge?
And if possible, could you also add a unit test for this to ensure this doesn't break pre and post workflow runs going forward?
There was a problem hiding this comment.
cc: @Fabianoshz friendly ping
also have you tested this change out in your own setup?
nitrocode
changed the title
nitrocode
approved these changes
Feb 18, 2023
ijames-gc
pushed a commit
to gocardless/atlantis
that referenced
this pull request
Feb 13, 2024
ijames-gc
pushed a commit
to gocardless/atlantis
that referenced
this pull request
Feb 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
what
why
tests
references
atlantis/post_workflow_hookdue to websocket 500 internalinvalid keyerror #3008