Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(renovatebot): automerge enabled #3123

Merged
merged 4 commits into from
Feb 17, 2023
Merged

feat(renovatebot): automerge enabled #3123

merged 4 commits into from
Feb 17, 2023

Conversation

nitrocode
Copy link
Member

@nitrocode nitrocode commented Feb 11, 2023

what

  • automerge enabled

  • verify required checks are set by repo owner

    runner / golangci-lint
    runner / revive
    runner / errcheck
    runner / gotest
    Analyze (go)
    Analyze (javascript)
    
  • need to create a generic test for each required check if the path filtering causes us to not run the check (see doc)

Any others?

why

  • once the repo owner sets required checks, automerge can be enabled for renovatebot pra
  • this will save maintainer time and get security/dependency updates in much sooner

tests

  • I have tested my changes by approving and merging many renovate prs. Ive closed all the failing ones so they should not cause issues.

references

@nitrocode nitrocode marked this pull request as ready for review February 11, 2023 01:14
@nitrocode nitrocode requested a review from a team as a code owner February 11, 2023 01:14
.github/renovate.json5 Outdated Show resolved Hide resolved
@nitrocode
Copy link
Member Author

cc @lkysow what do you think about adding the above individual checks as required so auto merge can be enabled on renovatebot?

@nitrocode
Copy link
Member Author

Thank you Luke! One other issue i didn't think about is handling the required checks if path filtering doesn't trigger them.

https://docs.github.com/en/repositories/configuring-branches-and-merges-in-your-repository/defining-the-mergeability-of-pull-requests/troubleshooting-required-status-checks#handling-skipped-but-required-checks

We can do this, as per gh docs, by creating generic runs (that run on the opposite path following) for each required check.

I added this as a line item for this pr above.

@nitrocode nitrocode enabled auto-merge (squash) February 17, 2023 05:27
@nitrocode nitrocode merged commit 49bc17d into main Feb 17, 2023
@nitrocode nitrocode deleted the renovatebot-automerge branch February 17, 2023 05:44
@nitrocode nitrocode added this to the v0.23.0 milestone Feb 17, 2023
ijames-gc pushed a commit to gocardless/atlantis that referenced this pull request Feb 13, 2024
* feat(renovatebot): automerge enabled

* Update renovate.json5

* feat(workflows): add negative path filtering for required tests
ijames-gc pushed a commit to gocardless/atlantis that referenced this pull request Feb 13, 2024
* feat(renovatebot): automerge enabled

* Update renovate.json5

* feat(workflows): add negative path filtering for required tests
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Enable renovatebots automerge
3 participants