Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(kustomize): Use k8s recommended name label #3261

Merged
merged 1 commit into from
Mar 30, 2023
Merged

fix(kustomize): Use k8s recommended name label #3261

merged 1 commit into from
Mar 30, 2023

Conversation

shouichi
Copy link
Contributor

@shouichi shouichi commented Mar 24, 2023 •
edited by nitrocode
Loading

what

  • set recommended k8s name label

why

  • recommended by docs

references

@shouichi shouichi requested a review from a team as a code owner March 24, 2023 09:18
@github-actions github-actions bot added the docs Documentation label Mar 24, 2023
@jamengual
Copy link
Contributor

this would be a breaking change, no? the pods will be restarted if the label changes?

@shouichi
Copy link
Contributor Author

Actually, StatefulSet won't allow us to update labels. We need to recreate it.

@nitrocode nitrocode changed the title Use k8s recommended label fix(kustomize): Use k8s recommended name label Mar 30, 2023
@nitrocode nitrocode added this to the v0.23.4 milestone Mar 30, 2023
@nitrocode nitrocode merged commit f8d6aac into runatlantis:main Mar 30, 2023
@shouichi shouichi deleted the use-recommended-label branch March 30, 2023 03:57
nitrocode pushed a commit that referenced this pull request May 5, 2023
@shouichi @nitrocode
fix(kustomize): Use k8s recommended name label (#3261)
450b8d3 
See https://kubernetes.io/docs/concepts/overview/working-with-objects/common-labels/#labels.
@albertorm95 albertorm95 mentioned this pull request May 19, 2023
Merged
ijames-gc pushed a commit to gocardless/atlantis that referenced this pull request Feb 13, 2024
@shouichi @ijames-gc
fix(kustomize): Use k8s recommended name label (runatlantis#3261)
185b8a0 
See https://kubernetes.io/docs/concepts/overview/working-with-objects/common-labels/#labels.
ijames-gc pushed a commit to gocardless/atlantis that referenced this pull request Feb 13, 2024
@shouichi @ijames-gc
fix(kustomize): Use k8s recommended name label (runatlantis#3261)
f090cf8 
See https://kubernetes.io/docs/concepts/overview/working-with-objects/common-labels/#labels.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nitrocode nitrocode nitrocode approved these changes

Assignees
No one assigned
Labels
docs Documentation
Projects
None yet
Milestone
v0.23.4
Development

Successfully merging this pull request may close these issues.
3 participants
@shouichi @jamengual @nitrocode