Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: use markdown to display github comments truncation header #4885

Merged
merged 3 commits into from
Sep 12, 2024

Conversation

benoittoulme
Copy link
Contributor

what

This is a follow-up to #3905

  • I noticed the truncation header is not formatted properly, and looks kind of ugly:
    image

  • I propose to use github markdown notation instead to format the header as a warning message:
    image

why

  • better "UI"

tests

  • deployed atlantis 0.29.0 and tested the comment markdown on a github comment.

references

#3905

@benoittoulme benoittoulme requested review from a team as code owners August 30, 2024 17:18
@benoittoulme benoittoulme requested review from GenPage, lukemassa and X-Guardian and removed request for a team August 30, 2024 17:18
@github-actions github-actions bot added go Pull requests that update Go code provider/github labels Aug 30, 2024
@chenrui333 chenrui333 changed the title Use markdown to display github comments truncation header chore: use markdown to display github comments truncation header Sep 5, 2024
Copy link
Member

@chenrui333 chenrui333 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

make sense 👍

@chenrui333 chenrui333 merged commit 6b52bd7 into runatlantis:main Sep 12, 2024
29 of 30 checks passed
@benoittoulme
Copy link
Contributor Author

@chenrui333 as you reviewed this PR, you may be interested in the follow-up PR #4980
This PR caused an annoying bug that I would like to fix, being the one who introduced it...

a1k0u pushed a commit to a1k0u/atlantis that referenced this pull request Nov 1, 2024
…atlantis#4885)

Co-authored-by: Rui Chen <rui@chenrui.dev>
Signed-off-by: a1k0u <alko7enko@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
go Pull requests that update Go code provider/github ready to merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants