Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: only lookup user team memberships if using team authz #4903

Merged
merged 1 commit into from
Sep 6, 2024
Merged

fix: only lookup user team memberships if using team authz #4903

merged 1 commit into from
Sep 6, 2024

Conversation

nickking-brt
Copy link
Contributor

what

  • Reverts user team lookup behavior for autoplans to be conditional, instead of always performing a lookup

why

references

@nickking-brt nickking-brt requested review from a team as code owners September 6, 2024 18:46
@nickking-brt nickking-brt requested review from jamengual, nitrocode and X-Guardian and removed request for a team September 6, 2024 18:46
@github-actions github-actions bot added the go Pull requests that update Go code label Sep 6, 2024
jamengual
jamengual approved these changes Sep 6, 2024
View reviewed changes
Copy link
Contributor

@jamengual jamengual left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @nickking-brt again.

@jamengual jamengual merged commit 7981df5 into runatlantis:main Sep 6, 2024
29 checks passed
@nickking-brt nickking-brt deleted the fix/team-lookups branch September 10, 2024 18:16
@BrewTestBot BrewTestBot mentioned this pull request Sep 30, 2024
Merged
1 task
a1k0u pushed a commit to a1k0u/atlantis that referenced this pull request Nov 1, 2024
@nickking-brt @a1k0u
fix: only lookup user team memberships if using team authz (runatlant…
98a0af0 
…is#4903)

Signed-off-by: a1k0u <alko7enko@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jamengual jamengual jamengual approved these changes

@nitrocode nitrocode Awaiting requested review from nitrocode nitrocode is a code owner automatically assigned from runatlantis/core-contributors

@X-Guardian X-Guardian Awaiting requested review from X-Guardian X-Guardian is a code owner automatically assigned from runatlantis/core-contributors

Assignees
No one assigned
Labels
go Pull requests that update Go code
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@nickking-brt @jamengual