Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Update lock for e2e tests #4939

Merged
merged 2 commits into from
Sep 22, 2024

Conversation

meringu
Copy link
Contributor

@meringu meringu commented Sep 22, 2024

what

Fixes the e2e tests. Some open PRs are failing on the e2e tests with an outdated lockfile. I've updated the null provider from 3.2.2. to 3.2.3, and locked it with the same platforms is seemed to be locked with before:

terraform providers lock -platform=linux_amd64 -platform=linux_arm64 -platform=darwin_amd64 -platform=darwin_arm64 

Current error:

running "/usr/local/bin/terraform init -input=false" in "/tmp/TestSimpleWorkflow_terraformLockFilesimple_with_plan_comment_lockfile_staged3170145570/001/repos/runatlantis/atlantis-tests/2/default": exit status 1
Initializing the backend...
Initializing provider plugins...
- Reusing previous version of hashicorp/null from the dependency lock file

│ Error: Failed to query available provider packages

│ Could not retrieve the list of available versions for provider
│ hashicorp/null: locked provider registry.terraform.io/hashicorp/null 3.2.2
│ does not match configured version constraint 3.2.3; must use terraform init
│ -upgrade to allow selection of new versions

I didn't run the scripts/pin_ci_terraform_providers.sh script, as it seemed to make a bunch of changes that didn't change the behaviour, I think the files it edits may have been updated by hand.

why

Fixes test, thought best to raise in a separate PR, as it affects a few open PRs

tests

I have run make test-all locally, and it is passing on my machine. Hopefully this PR triggers the action, and it passes there too.

references

@meringu meringu requested review from a team as code owners September 22, 2024 22:57
@meringu meringu requested review from jamengual, lukemassa and X-Guardian and removed request for a team September 22, 2024 22:57
@meringu meringu changed the title Update lock for e2e tests fix: Update lock for e2e tests Sep 22, 2024
@dosubot dosubot bot added bug Something isn't working dependencies PRs that update a dependency file labels Sep 22, 2024
@meringu
Copy link
Contributor Author

meringu commented Sep 22, 2024

This hasn't triggered the e2e tests on actions. Here is the output from my local:

❯ make test-all                    
?       github.com/runatlantis/atlantis [no test files]
ok      github.com/runatlantis/atlantis/cmd     (cached)
ok      github.com/runatlantis/atlantis/server  (cached)
ok      github.com/runatlantis/atlantis/server/controllers      (cached)
?       github.com/runatlantis/atlantis/server/events/vcs/gitea [no test files]
?       github.com/runatlantis/atlantis/testdrive       [no test files]
ok      github.com/runatlantis/atlantis/server/controllers/events       206.223s
ok      github.com/runatlantis/atlantis/server/controllers/web_templates        (cached)
ok      github.com/runatlantis/atlantis/server/controllers/websocket    (cached)
ok      github.com/runatlantis/atlantis/server/core/config      (cached)
ok      github.com/runatlantis/atlantis/server/core/config/raw  (cached)
ok      github.com/runatlantis/atlantis/server/core/config/valid        (cached)
ok      github.com/runatlantis/atlantis/server/core/db  (cached)
ok      github.com/runatlantis/atlantis/server/core/locking     (cached)
ok      github.com/runatlantis/atlantis/server/core/redis       (cached)
ok      github.com/runatlantis/atlantis/server/core/runtime     (cached)
ok      github.com/runatlantis/atlantis/server/core/runtime/cache       (cached)
ok      github.com/runatlantis/atlantis/server/core/runtime/common      (cached)
ok      github.com/runatlantis/atlantis/server/core/runtime/models      (cached)
ok      github.com/runatlantis/atlantis/server/core/runtime/policy      (cached)
ok      github.com/runatlantis/atlantis/server/core/terraform   (cached)
ok      github.com/runatlantis/atlantis/server/events   (cached)
ok      github.com/runatlantis/atlantis/server/events/command   (cached)
ok      github.com/runatlantis/atlantis/server/events/models    (cached)
ok      github.com/runatlantis/atlantis/server/events/terraform/ansi    (cached)
ok      github.com/runatlantis/atlantis/server/events/vcs       (cached)
ok      github.com/runatlantis/atlantis/server/events/vcs/bitbucketcloud        (cached)
ok      github.com/runatlantis/atlantis/server/events/vcs/bitbucketserver       (cached)
ok      github.com/runatlantis/atlantis/server/events/vcs/common        (cached)
ok      github.com/runatlantis/atlantis/server/events/webhooks  (cached)
ok      github.com/runatlantis/atlantis/server/jobs     (cached)
ok      github.com/runatlantis/atlantis/server/logging  (cached)
ok      github.com/runatlantis/atlantis/server/metrics  (cached)
ok      github.com/runatlantis/atlantis/server/recovery (cached)
ok      github.com/runatlantis/atlantis/server/scheduled        (cached)
ok      github.com/runatlantis/atlantis/server/utils    (cached)

@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Sep 22, 2024
@chenrui333 chenrui333 merged commit 76b0148 into runatlantis:main Sep 22, 2024
31 checks passed
@chenrui333
Copy link
Member

Thanks @meringu!

@meringu meringu deleted the update-test-lockfile branch September 22, 2024 23:19
a1k0u pushed a commit to a1k0u/atlantis that referenced this pull request Nov 1, 2024
Signed-off-by: a1k0u <alko7enko@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working dependencies PRs that update a dependency file lgtm This PR has been approved by a maintainer
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants