-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Update lock for e2e tests #4939
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
meringu
requested review from
jamengual,
lukemassa and
X-Guardian
and removed request for
a team
September 22, 2024 22:57
dosubot
bot
added
bug
Something isn't working
dependencies
PRs that update a dependency file
labels
Sep 22, 2024
This hasn't triggered the e2e tests on actions. Here is the output from my local:
|
chenrui333
approved these changes
Sep 22, 2024
Thanks @meringu! |
1 task
a1k0u
pushed a commit
to a1k0u/atlantis
that referenced
this pull request
Nov 1, 2024
Signed-off-by: a1k0u <alko7enko@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
bug
Something isn't working
dependencies
PRs that update a dependency file
lgtm
This PR has been approved by a maintainer
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
what
Fixes the e2e tests. Some open PRs are failing on the e2e tests with an outdated lockfile. I've updated the null provider from 3.2.2. to 3.2.3, and locked it with the same platforms is seemed to be locked with before:
Current error:
I didn't run the
scripts/pin_ci_terraform_providers.sh
script, as it seemed to make a bunch of changes that didn't change the behaviour, I think the files it edits may have been updated by hand.why
Fixes test, thought best to raise in a separate PR, as it affects a few open PRs
tests
I have run
make test-all
locally, and it is passing on my machine. Hopefully this PR triggers the action, and it passes there too.references