Implement a high-accessibility canvastable alternative #863
Conversation
tadzik
force-pushed
the
tadzik/decouple-canvastable
branch
3 times, most recently
from
adbd270
to
b416f55
Compare
|
Good initiative @tadzik! |
tadzik
force-pushed
the
tadzik/decouple-canvastable
branch
4 times, most recently
from
c617875
to
a4d0bf6
Compare
tadzik
changed the title
tadzik
force-pushed
the
tadzik/decouple-canvastable
branch
from
a4d0bf6
to
f702279
Compare
| [ngClass]="{ 'messageButton': true, 'selectedFolder': rows.openedRowIndex == row.rowid }" | ||
| (click)="openMessage(row.rowid)" | ||
| > | ||
| <div class="firstRow"> |
There was a problem hiding this comment.
Looks like this hard codes the set of columns displayed - which won't quite DWIM when showing search results, or the "Sent" folder.. could it use the canvastablecolumns stuff somehow?
There was a problem hiding this comment.
It does, though it cheats a little by hardcoding the header column to be either From or Sent. Not very future-proof, but that's the best we've got right now I think.
|
Any particular reason the new view isnt an HTML table? its a little confusing as a list, especially when clicking "threaded" .. cant tell what that does at all - view just jumps/redraws |
|
Couldnt see the "Next N messages" button at first - it disappears when the horizontal view pane is displayed |
|
Up/down pages the messages (by 10) on the non-canvas list.. this is quite confusing/different to the canvastable.. Maybe that should be pageup/down instead? |
tadzik
force-pushed
the
tadzik/decouple-canvastable
branch
from
f702279
to
2f38f60
Compare
…lay implementations They're dependent on one another anyway, we may as well make it official (and beneficial).
Not only it doesn't appear to do anything useful, it also couples App (more) strongly to canvastable internals and also throws a bunch of nasty exceptions whenever and index is deleted.
Decreases coupling by another tiny bit.
…ct to visible rows changing
This will allow us to swap it "easily" for something else.
…tion when not needed
…elist is initialized
tadzik
force-pushed
the
tadzik/decouple-canvastable
branch
from
2f38f60
to
63ef200
Compare
|
Changing folders does not set the current page, so if I vist Sent, page forward a few pages, then visit Templates (or something with less pages), I get this view. I think the default should be to jump to page 1, when changing folders. |
|
I could be missing something, or you lost it in a shuffle - when an email is open, there doesn't seem to be an indication of which one it is, in the mail list - row hightlight or similar
|
|
The Attachment / Flag columns are missing - I would think they'd be possible to do? |
This loosens the coupling between AppComponent and CanvasTable, allowing us to switch between alternative canvastable implementations (which currently requires a page reload, given how interconnected everything still is). It also ships an optional simplified messagelist, using native HTML widgets which should mitigate canvas's inherent problems described in #857.
The alternative messagelist is not fully functional (yet), but the basic functionality and styling are open to testing, criticism and patches.