Add tests for ListGroup #43
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rundis
reviewed
Apr 14, 2017
tests/Bootstrap/ListGroupTest.elm
Outdated
| [ ListGroup.li [] [ text "List item 1" ] | ||
| ] | ||
|
|
||
| active = |
There was a problem hiding this comment.
Why not just put an active item and disabled item in the list for html and then have assertions for 0, 1, 2 indexed items ?
tests/Bootstrap/ListGroupTest.elm
Outdated
| \() -> | ||
| html | ||
| |> Query.fromHtml | ||
| |> Query.has [ tag "li", Selector.disabled False ] |
There was a problem hiding this comment.
This assertion strikes me as a bit odd. I can sort of understand it, but if we are to test everything that should not be set... there's a lot you need to assert.
tests/Bootstrap/ListGroupTest.elm
Outdated
| {-| The fact that an element is keyed is not visible from the dom, so | ||
| this just tests that the keyed versions produce the same html as the "vanilla" ones | ||
| -} | ||
| keyedListGroup : Test |
There was a problem hiding this comment.
Yeah, I think it might be worth extracting all that's common between vanilla and keyed into a separate function used by both.
| ] | ||
|
|
||
|
|
||
| contextualListGroup : Test |
|
The above commit uses the same test for normal and keyed, and fixes the other problems you raised. |
|
Looking good ! Tx. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
would like a quick second pair of eyeballs on this.
In particular the tests for keyed elements. I've copied tests for the normal elements to check the keyed ones produce the same html. Maybe it would be better to define the tests once as a function taking a
Html msg, then applying that function to a standard and a keyed piece of html?