Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update music-replacer #3065

Merged
merged 2 commits into from
Aug 1, 2022
Merged

Conversation

alowaniak
Copy link
Contributor

Add mp3 support, file chooser for local, and presets

@runelite-github-app
Copy link

runelite-github-app bot commented Jul 25, 2022

@LlemonDuck
Copy link
Contributor

You should be using the Maven library system where possible to import libraries instead of storing entire JAR files in your repository. I'm not sure if JACo is available through any Maven repositories, but you are free under the terms to include the source fully within your own source code. This is a large library and will depend on one of our reviewers taking the time to read through that entire source as well.

Also, your use of the library currently does not abide by its LGPL licensing terms. At minimum you need to include a copy of the original licensing terms, provide attribution, and provide the source code. You also may not re-license the code under your own BSD license that you are currently using.

@alowaniak
Copy link
Contributor Author

JaCo isn't available in a maven repo AFAIK.
I took the same approach as the fire-beats plugin, and in fact used the same library assuming that could expedite the review since it's been accepted before.

For abiding by the LGPL licensing terms would it be enough to:

  • Add a copy of the lgpl in music-replacer repo
  • Provide attribution in the README
  • Add a link to jaco's repo in the README's attribution section
    ?

@alowaniak
Copy link
Contributor Author

I've added a copy of the LGPL license, linked to the JaCo source and gave attribution.

(Also fixed the plugin since it broke after widget ID change last osrs update.)

@Nightfirecat Nightfirecat merged commit 17bf8f5 into runelite:master Aug 1, 2022
@alowaniak alowaniak deleted the music-replacer branch August 13, 2022 23:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants