Update wilderness player alarm #6276
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Apologies for the back-to-back PRs on the same plug-in. There was a slight regression in #6239 that I slipped in:
With the homemade timeout functionality that I removed, there was logic to check the players in range each tick such that the alarm would go off whenever someone new entered the alarm radius. With the migration to notification overrides, I deleted a lot of that. As a consequence, once a user has been notified of a player nearby, they won't get notified again until they are completely alone or exit & re-enter the dangerous area.
This small change will cause the alarm to trip anew when more players enter the alarm radius, which is useful for places like chaos altar or revs where there may be individuals co-existing and then a new player shows up.