fix no-missing-import getting confused on incremental file changes #338
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AndrewJakubowicz
commented
Jan 5, 2024
Comment on lines
+171
to
+180
| if (result == null) { | ||
| // Result could not be found from the cache, try and resolve module without using the | ||
| // cache. | ||
| result = context.ts.resolveModuleName( | ||
| moduleSpecifier, | ||
| node.getSourceFile().fileName, | ||
| context.program.getCompilerOptions(), | ||
| context.ts.createCompilerHost(context.program.getCompilerOptions()) | ||
| ); | ||
| } |
There was a problem hiding this comment.
This fixes the issue. The rest of the PR is refactor & tests
rictic
reviewed
Jan 5, 2024
| @@ -285,6 +285,6 @@ export class DefaultLitAnalyzerContext implements LitAnalyzerContext { | |||
|
|
|||
| // Build a graph of component dependencies | |||
| const res = parseDependencies(file, this); | |||
| this.dependencyStore.importedComponentDefinitionsInFile.set(file.fileName, res); | |||
| this.dependencyStore.absorbComponentDefinitionsForFile(file, res); | |||
There was a problem hiding this comment.
What's the difference between these methods?
There was a problem hiding this comment.
There is no difference except it looked like the intent was that importedComponentDefinitionsInFile should be private, with absorbComponentDefinitionsForFile being the public method to do this logic.
You can see the dependencyStore class defined here: https://github.com/runem/lit-analyzer/pull/338/files#diff-faaba94b3ffda920023b5e0ff3b54f7137199117142a418b7bd79df7e8951c5eR6-R9
This is a pure refactor, no logic change. I can revert this line if it keeps it simpler.
This was referenced Jan 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
See the following video to preview the issue:
lit-no-import-error.mov
This screen recording captures the integration test created by @benjamind in #335
Fix
This was a rough issue to debug. Ultimately the TypeScript cache seems to sometimes not contain the files required to resolve the module specifier string. The fix is to handle this case by resolving the module specifier without using the cache.
This graceful fallback causes the integration test to pass. I also manually verified that the fix works.
Other changes
I also did a small amount of cleanup removing some commented out code and tiny changes as I had to go pretty deep to find this issue.