Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Doc edits/additions still do not pass the required checks due to the e2e test matrix strategy #22

Closed
weikequ opened this issue Nov 22, 2022 · 0 comments · Fixed by #24
Closed

Doc edits/additions still do not pass the required checks due to the e2e test matrix strategy #22

weikequ opened this issue Nov 22, 2022 · 0 comments · Fixed by #24
Assignees
@weikequ
Labels
bug Something isn't working

Comments

@weikequ
Copy link
Contributor

weikequ commented Nov 22, 2022

Describe the bug

  • Doc edits/additions still do not pass the required checks due to the e2e test matrix strategy necessitating the matrix be expanded before the checks passes.

Steps to reproduce

  • Edit a doc.
  • Create a PR.
  • See that most CI is successful, including the e2e tests one
  • See that the specific e2e tests for each platform is still pending.

Expected behavior

  • Expectation is when a PR only contains doc changes, e2e test status check for all platforms are skipped.
@weikequ weikequ added the bug Something isn't working label Nov 22, 2022
@weikequ weikequ self-assigned this Nov 22, 2022
@weikequ weikequ mentioned this issue Nov 22, 2022
Merged
1 task
@weikequ weikequ linked a pull request Nov 22, 2022 that will close this issue
fix: add full matrix strategy to generic docs ci #24
Merged
1 task
weikequ added a commit that referenced this issue Nov 22, 2022
@weikequ
fix: add full matrix strategy to generic docs ci (#24)
77b09bf 
Signed-off-by: Weike Qu <weikequ@amazon.com>

Issue #, if available:
- #22

*Description of changes:*
- Added matrix strategy to reflect status check requirement

*Testing done:*



- [x] I've reviewed the guidance in CONTRIBUTING.md


#### License Acceptance

By submitting this pull request, I confirm that my contribution is made
under the terms of the Apache 2.0 license.

Signed-off-by: Weike Qu <weikequ@amazon.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@weikequ weikequ

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
1 participant
@weikequ