-
Notifications
You must be signed in to change notification settings - Fork 94
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Add Dockercompat Mode & DevContainer Support #1100
Conversation
d31230d
to
b957996
Compare
9a7ecd8
to
999371e
Compare
With commit 999371e, I resolved the Unfortunately, my devContainers experiment was now able to build an image, but unable to open it due to the length of identifier.
|
999371e
to
852f4f6
Compare
de74f5b
to
9672022
Compare
The update to commit 9672022 is an incremental improvement:
|
4afe739
to
8cfbc1f
Compare
Signed-off-by: Sam Chew <stchew@amazon.com>
8cfbc1f
to
1703acd
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There are still linting errors, but LGTM as long as all of the automated approval workflows pass
1703acd
to
baa403f
Compare
baa403f
to
c8ed9dd
Compare
Signed-off-by: Sam Chew <stchew@amazon.com>
c8ed9dd
to
d9e9d75
Compare
Issue #, if available: #387, #745
Description of changes:
This PR will introduce parsing changes to support docker compatibility for various DevContainer invocations from VsCode.
The introduction of
dockercompat: true
within Finch configuration will specifically activate certain Finch behavior to map Docker cli arguments to compatible nerdctl arguments.Testing done:
Manual testing on Apple M1 (arm64) launching devContainers via VsCode
Unit Tests
Pre-existing E2E Tests
I've reviewed the guidance in CONTRIBUTING.md
License Acceptance
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.