fix(linux): DOCKER_CONFIG path #1102
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Justin Alvarez <alvajus@amazon.com>
pkg/path/finch_linux.go
Outdated
| @@ -34,6 +34,11 @@ func (fp Finch) BuildkitSocketPath() string { | |||
| return filepath.Join(fp.FinchRuntimeDataDir(), "buildkit", "buildkitd.sock") | |||
| } | |||
|
|
|||
| // DockerConfigPath returns the path to the docker config file. | |||
| func (fp Finch) DockerConfigPath() string { | |||
There was a problem hiding this comment.
DockerConfigDir?
Also, should we add a comment here that nerdctl uses ${DOCKER_CONFIG}/config.json for the authentication with image registries.
There was a problem hiding this comment.
Fixed in latest revision
Signed-off-by: Justin Alvarez <alvajus@amazon.com>
pendo324
requested review from
swagatbora90
and removed request for
swagatbora90
swagatbora90
approved these changes
Sep 23, 2024
pendo324
added a commit
to pendo324/finch
that referenced
this pull request
Sep 23, 2024
This reverts commit 5b45b75. Signed-off-by: Justin Alvarez <alvajus@amazon.com>
1 task
pendo324
added a commit
that referenced
this pull request
Sep 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
Description of changes:
Testing done:
License Acceptance
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.