Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: Update homebrew cask new dir #536

Merged
merged 1 commit into from
Aug 16, 2023
Merged

ci: Update homebrew cask new dir #536

merged 1 commit into from
Aug 16, 2023

Conversation

KevinLiAWS
Copy link
Contributor

Issue #, if available:
Homebrew cask now partion its formulas by sub-folder, e.g., finch is uder ./Cask/f/finch.rb instead of ./Cask/finch.rb
This is a regression from homebrew cask which breaks our homebrew release automation.

Description of changes:
This pr updated the path in all places to unblock 0.8.0 release.

Testing done:
Will exercise the updated action after the PR checked in

  • I've reviewed the guidance in CONTRIBUTING.md

License Acceptance

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

Signed-off-by: Kevin Li <cnkevin@amazon.com>
@KevinLiAWS KevinLiAWS requested a review from a team as a code owner August 16, 2023 23:07
Copy link
Contributor

@vsiravar vsiravar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, is it possible to add a link for the homebrew change in this PR? Will be helpful in the future.

@KevinLiAWS
Copy link
Contributor Author

Homebrew Cask change reference: https://github.com/Homebrew/homebrew-cask/pull/152603/files

@KevinLiAWS KevinLiAWS merged commit bbdd782 into main Aug 16, 2023
12 checks passed
@KevinLiAWS KevinLiAWS deleted the fix-homebrew-cask branch August 16, 2023 23:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants