Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: make Virtualization Framework default #956

Merged
merged 5 commits into from
May 23, 2024
Merged

feat: make Virtualization Framework default #956

merged 5 commits into from
May 23, 2024

Conversation

pendo324
Copy link
Member

Issue #, if available:

Description of changes:
Makes virtualization framework (vz) the default vmType option, when its available

Testing done:

  • local testing

  • unit testing

  • e2e testing

  • I've reviewed the guidance in CONTRIBUTING.md

License Acceptance

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@pendo324
feat: make Virtualization Framework default
694e7c1 
Signed-off-by: Justin Alvarez <alvajus@amazon.com>
@pendo324 pendo324 requested a review from a team May 17, 2024 22:48
@pendo324 pendo324 self-assigned this May 17, 2024
@pendo324
refactor defaults per-OS
d1f41d3 
Signed-off-by: Justin Alvarez <alvajus@amazon.com>
@pendo324
lint
c92178a 
Signed-off-by: Justin Alvarez <alvajus@amazon.com>
@pendo324
fix type mismatch
0114761 
Signed-off-by: Justin Alvarez <alvajus@amazon.com>
@AkihiroSuda AkihiroSuda mentioned this pull request May 20, 2024
Merged
Shubhranshu153
Shubhranshu153 previously approved these changes May 22, 2024
View reviewed changes
pkg/config/defaults_darwin.go Outdated Show resolved Hide resolved
@pendo324
default to qemu-user emulation instead of Rosetta
d3ebbdc 
Signed-off-by: Justin Alvarez <alvajus@amazon.com>
@pendo324 pendo324 merged commit 75b69b8 into runfinch:main May 23, 2024
35 checks passed
@github-actions github-actions bot mentioned this pull request May 23, 2024
Merged
henry118 pushed a commit that referenced this pull request Jun 3, 2024
@github-actions
chore(main): release 1.2.0 (#883)
7fc3104 
🤖 I have created a release *beep* *boop*
---


## [1.2.0](v1.1.3...v1.2.0)
(2024-06-03)


### Build System or External Dependencies

* **deps:** Bump github.com/aws/aws-sdk-go-v2 from 1.26.0 to 1.26.1
([#882](#882))
([c059d9e](c059d9e))
* **deps:** Bump github.com/aws/aws-sdk-go-v2 from 1.26.1 to 1.27.0
([#954](#954))
([b06280c](b06280c))
* **deps:** Bump github.com/docker/cli from 26.0.0+incompatible to
26.0.1+incompatible
([#894](#894))
([680e23f](680e23f))
* **deps:** Bump github.com/docker/cli from 26.0.1+incompatible to
26.0.2+incompatible
([#906](#906))
([6fc6ce5](6fc6ce5))
* **deps:** Bump github.com/docker/cli from 26.0.2+incompatible to
26.1.0+incompatible
([#913](#913))
([bfeb585](bfeb585))
* **deps:** Bump github.com/docker/cli from 26.1.0+incompatible to
26.1.1+incompatible
([#922](#922))
([7b6b3d2](7b6b3d2))
* **deps:** Bump github.com/docker/cli from 26.1.1+incompatible to
26.1.2+incompatible
([#941](#941))
([eec3462](eec3462))
* **deps:** Bump github.com/docker/cli from 26.1.2+incompatible to
26.1.3+incompatible
([#952](#952))
([9a94c57](9a94c57))
* **deps:** Bump github.com/docker/docker from 26.0.0+incompatible to
26.0.1+incompatible
([#892](#892))
([05610c1](05610c1))
* **deps:** Bump github.com/docker/docker from 26.0.1+incompatible to
26.0.2+incompatible
([#905](#905))
([69e7d0b](69e7d0b))
* **deps:** Bump github.com/docker/docker from 26.0.2+incompatible to
26.1.0+incompatible
([#912](#912))
([5e5f8a8](5e5f8a8))
* **deps:** Bump github.com/docker/docker from 26.1.0+incompatible to
26.1.1+incompatible
([#924](#924))
([79eb863](79eb863))
* **deps:** Bump github.com/docker/docker from 26.1.1+incompatible to
26.1.2+incompatible
([#940](#940))
([aa3ab01](aa3ab01))
* **deps:** Bump github.com/docker/docker from 26.1.2+incompatible to
26.1.3+incompatible
([#951](#951))
([cef9d8f](cef9d8f))
* **deps:** Bump github.com/lima-vm/lima from 0.21.0 to 0.22.0
([#934](#934))
([62d67d5](62d67d5))
* **deps:** Bump github.com/onsi/ginkgo/v2 from 2.17.1 to 2.17.2
([#920](#920))
([939639e](939639e))
* **deps:** Bump github.com/onsi/ginkgo/v2 from 2.17.2 to 2.17.3
([#933](#933))
([c56019d](c56019d))
* **deps:** Bump github.com/onsi/ginkgo/v2 from 2.17.3 to 2.19.0
([#959](#959))
([08d7a34](08d7a34))
* **deps:** Bump github.com/onsi/gomega from 1.33.0 to 1.33.1
([#923](#923))
([e7f4e0d](e7f4e0d))
* **deps:** Bump github.com/runfinch/common-tests from 0.7.18 to 0.7.21
([#878](#878))
([e1cbd0a](e1cbd0a))
* **deps:** Bump github.com/runfinch/common-tests from 0.7.21 to 0.7.22
([#907](#907))
([84b4a69](84b4a69))
* **deps:** Bump github.com/shirou/gopsutil/v3 from 3.24.2 to 3.24.3
([#881](#881))
([465e369](465e369))
* **deps:** Bump github.com/shirou/gopsutil/v3 from 3.24.3 to 3.24.4
([#925](#925))
([8cd5643](8cd5643))
* **deps:** Bump github.com/shirou/gopsutil/v3 from 3.24.4 to 3.24.5
([#962](#962))
([8e51db3](8e51db3))
* **deps:** Bump github.com/tc-hib/go-winres from 0.3.1 to 0.3.3
([#893](#893))
([ebb4c9f](ebb4c9f))
* **deps:** Bump golang.org/x/crypto from 0.22.0 to 0.23.0
([#928](#928))
([1687293](1687293))
* **deps:** Bump golang.org/x/text from 0.14.0 to 0.15.0
([#929](#929))
([85e1bec](85e1bec))
* **deps:** Bump golang.org/x/tools from 0.19.0 to 0.20.0
([#889](#889))
([cfac010](cfac010))
* **deps:** Bump golang.org/x/tools from 0.20.0 to 0.21.0
([#932](#932))
([a853a8a](a853a8a))
* **deps:** Bump k8s.io/apimachinery from 0.29.3 to 0.30.0
([#904](#904))
([f8b7f25](f8b7f25))
* **deps:** Bump k8s.io/apimachinery from 0.30.0 to 0.30.1
([#946](#946))
([dc4ebf9](dc4ebf9))
* **deps:** Bump submodules and dependencies
([#874](#874))
([a9f73be](a9f73be))
* **deps:** Bump submodules and dependencies
([#895](#895))
([c7388bb](c7388bb))
* unify macos/windows yamls
([#921](#921))
([86d9a23](86d9a23))


### Features

* Add the --format option to the finch version command
([#926](#926))
([a9d04e3](a9d04e3))
* make Virtualization Framework default
([#956](#956))
([75b69b8](75b69b8))


### Bug Fixes

* add finch vm settings subcommand
([#887](#887))
([8e809cc](8e809cc))
* Remove unnecessary error handling
([#961](#961))
([f441fc9](f441fc9))

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jandubois jandubois jandubois left review comments

@Shubhranshu153 Shubhranshu153 Shubhranshu153 approved these changes

@swagatbora90 swagatbora90 swagatbora90 approved these changes

@henry118 henry118 henry118 approved these changes

Assignees

@pendo324 pendo324

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@pendo324 @jandubois @henry118 @swagatbora90 @Shubhranshu153