-
Notifications
You must be signed in to change notification settings - Fork 43
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Go through and remove redundant if (IsDZelnodeActive()) checks #173
Comments
In the current master there are no references to IsDZelnodeActive, this issue can be closed |
@w2vy what about IsDFluxnodeActive? |
Good point, those I will look at to understand better and then we can talk about which can go. |
@blondfrogs I went back to v5.2.0 (before I touched anything) and the instances of IsDZelnodeActive were the same. I do see in main.cpp (ConnectBlock), miner.cpp (CreateNewBlock) and zelnode.cpp (rebuildfluxnodedb) So it seems IsDFluxnodeActive is only used in the RPC calls. |
@w2vy That sounds correct. Lets get together and see if we need them anymore. |
closed with PR#192 |
Now that deterministic zelnodes is active on mainnet for a while. Some places don't need to check if it is active anymore.
This include rpc calls, and some consensus code. We should be careful when removing this check as in some places if could save time while syncing blocks earlier in the chain.
The text was updated successfully, but these errors were encountered: