Skip to content
This repository was archived by the owner on Aug 31, 2021. It is now read-only.

Conversation

angerangel
Copy link
Contributor

@livecodeali
Copy link
Member

Hi MaxV,

Unfortunately we cannot accept outside contributions to binary stack files, as without being able to see the diff we can't review the changes. We can only do that with 'script only' stacks.

If you would like to describe the exact changes in your fix we can implement them here.

@angerangel
Copy link
Contributor Author

Don't you have a livecode diff viewer? Are you serious?
However I corrected the path in linux environment, it pointed to revSpecialFolderPath("documents") but that path doesn't work on linux.
P.S. do you need a livecode diff viewer?

@angerangel
Copy link
Contributor Author

The code is in Stack and is the following change:

on preOpenStack
   local tDatabaseFile
   #check specialFolderPath("documents") is not empty
   if specialFolderPath("documents") is not empty then      
   ## Connect to the SQLite database using the database file path
      put specialFolderPath("documents") & "/bookLibrary.sqlite" into tDatabaseFile
   else
      put specialFolderPath("temporary") & "/bookLibrary.sqlite" into tDatabaseFile
   end if

@livecodeali
Copy link
Member

The problem is that we don't have something that can show the complete diff for two binary stackfiles. It would be possible to hide malicious code in the scripts of various other objects, or alter the value of an important custom property, or move objects around or delete them, or add unwanted objects etc. I'm not saying that you're at all likely to have done any of those things!

@livecodeali
Copy link
Member

Implemented here:
#211

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants