This repository was archived by the owner on Aug 31, 2021. It is now read-only.
[[ Bug 8884 ]] removed stack password and passkey, removed field padding... #82
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ing, fixed trytoconvertutf16tonative so it actually copies the converted string to the exec point
| @@ -994,12 +994,17 @@ bool MCExecPoint::trytoconvertutf16tonative() | |||
| MCExecPoint t_other_ep; | |||
| t_other_ep . setsvalue(getsvalue()); | |||
| t_other_ep . utf16tonative(); | |||
|
|
|||
| // MERG-2013-05-07: [[ Bug 8884 ]] If returning true the function setting back to utf16 instead of to native | |||
| MCString t_string = t_other_ep . getsvalue(); | |||
There was a problem hiding this comment.
This isn't quite correct - getsvalue() is just a 'get', i.e. it doesn't copy the data so it will potentially get clobbered by the next line... I suggest doing:
MCExecPoint t_temp_ep;
t_temp_ep . setsvalue(t_other_ep . getsvalue());
t_temp_ep . nativetoutf16();Then use t_temp_ep in the next comparison. This way, 't_other_ep' still contains the native version for the return (if roundtrip succeeds).
There was a problem hiding this comment.
OK, it seems to work fine but better safe than sorry.
added 3 commits
July 10, 2013 06:46
…ing back to utf16
Tagged for 6.1.0 release. Conflicts: engine/src/execpt.cpp
|
Sorry, changes to the Xcode project files were not necessary for the fixes. Not sure why the merge created a diff there. |
|
merged into release-6.1.1 branch |
trevordevore
pushed a commit
to trevordevore/livecode
that referenced
this pull request
Jul 7, 2015
[[ Property Inspector ]] Temporarily remove custom property tab from property inspector
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
..., fixed trytoconvertutf16tonative so it actually copies the converted string to the exec point