-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Verify proveX
and checkX
functions similarly to testX
#249
Conversation
test
/testFail
test
/testFail
correctly
test
/testFail
correctlytest
/testFail
correctly
As highlighted by @RaoulSchaffranek and @anvacaru, some of our use-cases such as the debugger and CSE require executing functions that do not start with |
Based on the discussion in today's standup, we decided to handle tests prefixed with cc @JuanCoRo |
2d1b80f
to
1df89b6
Compare
test
/testFail
correctlyproveX
functions similarly to testX
proveX
functions similarly to testX
proveX
functions similarly to testX
proveX
functions similarly to testX
proveX
and checkX
functions similarly to testX
Can you test this by renaming one of the existing tests (for which we check the output) with the new prefixes? |
@anvacaru I renamed one of the tests for which we check expected output from Please let me know if you think we should test it more exhaustively, and thank you for all the suggestions! |
Closes #247.
Currently, this PR adds an error that is thrown if any of the function names provided with--match-test
do not start withtest
ortestFail
, but should be refactored.At the moment, only functions starting with
test
andtestFail
are checked for Foundry success predicate and will fail if the function reverts. There are two issues with this approach:test
/testFail
are picked up for fuzzing during aforge test
run, and we don't provide a way to specify Kontrol-specific functionsThe changes introduced in this PR include:
prove
andcheck
prefixes similarly to those starting withtest
prove_assert_true()
; this test is skipped in the legacy CI in order to not increase it's runtime and since the change is relatively minor