Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

readme: add prerequesite and logging, improve config #86

Merged
merged 4 commits into from
Jul 5, 2021

Conversation

Mirko-von-Leipzig
Copy link
Contributor

@Mirko-von-Leipzig Mirko-von-Leipzig commented Jul 5, 2021

I'm not certain if this would be enough information for a novice -- but it might be enough for someone familiar with Zebra / ZCashd?

I've also removed the config field for setting the config file in anticipation of #85 getting merged.

Copy link
Collaborator

@niklaslong niklaslong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! I think this is detailed enough, especially as most users of the project will be devs familiar with either zebrad, zcashd or both.

README.md Outdated Show resolved Hide resolved
@niklaslong
Copy link
Collaborator

Clippy breakage may be due to rust-lang/rust-clippy#7422.

@Mirko-von-Leipzig
Copy link
Contributor Author

Clippy breakage may be due to rust-lang/rust-clippy#7422.

Yeah I think that's the cause. Only broke for me locally after rustup update

@niklaslong
Copy link
Collaborator

niklaslong commented Jul 5, 2021

Let's wait for #85 so we're in sync.

@niklaslong niklaslong merged commit 3e14b73 into master Jul 5, 2021
@niklaslong niklaslong deleted the docs/readme branch July 5, 2021 11:07
zeapoz pushed a commit to zeapoz/zcash that referenced this pull request Apr 13, 2023
readme: add prerequesite and logging, improve config
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants