Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Also don't match the root directory #216

Merged
merged 1 commit into from
May 26, 2021
Merged

Also don't match the root directory #216

merged 1 commit into from
May 26, 2021

Conversation

ericbn
Copy link
Contributor

@ericbn ericbn commented Oct 20, 2017

besides the $HOME directory.

A z / call will cd to the root directory anyway, because of how the code handles completion:

# if we hit enter on a completion just go there
case "$last" in
    # completions will always start with /
    /*) [ -z "$list" -a -d "$last" ] && builtin cd "$last" && return;;
esac

besides the `$HOME` directory.

A `z /` call will cd to the root directory anyway, because of how the
code handles completion:

    # if we hit enter on a completion just go there
    case "$last" in
        # completions will always start with /
        /*) [ -z "$list" -a -d "$last" ] && builtin cd "$last" && return;;
    esac
Copy link

@dmd dmd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense and no downside.

@rupa rupa merged commit 574f64b into rupa:master May 26, 2021
@ericbn ericbn deleted the rootdir branch May 26, 2021 20:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants