Abort tiled upscale if using OpenVINO #129
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Abort tiled upscale if using OpenVINO
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It seems the error when using tiled upscale with OpenVINO models is related to the output resolution for the generated images; the current code for tiled upscale uses arbitrary resolutions, which is not really compatible with OpenVINO anyway given that OpenVINO models have to be recompiled whenever output resolution changes; with the current tiled upscale code, OpenVINO models would require recompilation at every tile generation.
So, for the time being, it's best to abort execution of the tiled upscale when the use_openvino argument is set.