-
-
Notifications
You must be signed in to change notification settings - Fork 66
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
unify error messages, save memory #19
Labels
Comments
Measured the impact: with the new errorhandling code and global errmsg table we need 30kb more, changed funcs for testing: vsnprintf_s, vsprintf_s, swprintf_s, vswprintf_s massif test script: (darwin)
|
rurban
added a commit
that referenced
this issue
Sep 30, 2017
Using less memory is more important here. See GH #19
rurban
added a commit
that referenced
this issue
Sep 30, 2017
Using less memory is more important here, but the impact is negative. while there is ~30kb more memory for the new safe_strerr there's no win in using it. the compiler is already good enough in merging the constant strings. See GH #19, rejected.
rurban
added a commit
that referenced
this issue
Sep 30, 2017
Using less memory is more important here, but the impact is negative. while there is ~30kb more memory for the new safe_strerr there's no win in using it. the compiler is already good enough in merging the constant strings. See GH #19, rejected.
rurban
added a commit
that referenced
this issue
Oct 1, 2017
Using less memory is more important here, but the impact is negative. while there is ~30kb more memory for the new safe_strerr there's no win in using it. the compiler is already good enough in merging the constant strings. See GH #19, rejected.
rurban
added a commit
that referenced
this issue
Oct 3, 2017
Using less memory is more important here, but the impact is negative. while there is ~30kb more memory for the new safe_strerr there's no win in using it. the compiler is already good enough in merging the constant strings. See GH #19, rejected.
rurban
added a commit
that referenced
this issue
Oct 3, 2017
Using less memory is more important here, but the impact is negative. while there is ~30kb more memory for the new safe_strerr there's no win in using it. the compiler is already good enough in merging the constant strings. See GH #19, rejected.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Currently the error messages are customized to include the function name as prefix, and the argument name.
This is great for the user, but most likely memory overkill.
Normal libc's have a unique error message per number, stored globally only once. Not 100x times.
Measure the memory impact.
possibly convert to unified strings
or to
fprintf("%s: %s message", __FUNCTION__, "dest")
, so we can share at least the base message.The text was updated successfully, but these errors were encountered: