Add current url to feedback link #96
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
特に何もなさそうだったので、とりあえずマージして様子を見てみます。 |
hanachin
reviewed
Feb 4, 2020
| @@ -21,7 +21,8 @@ | |||
| <img alt="Creative Commons License" style="border-width:0" src="https://i.creativecommons.org/l/by/3.0/88x31.png" /> | |||
| </a> | |||
|
|
|||
| フィードバックは<a href="https://github.com/rurema/doctree">こちら</a> | |||
| フィードバックは<a href="https://github.com/rurema/doctree/issues/new" id="feedback-link">こちら</a> | |||
| <script>document.getElementById("feedback-link").search = new URLSearchParams({'body': document.location});</script> | |||
There was a problem hiding this comment.
IE11ではエラーになりそうですが静的なページなはずのでJavaSciptでエラーでて止まっても特に問題ないのかな...?
https://caniuse.com/#feat=urlsearchparams
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://help.github.com/en/github/managing-your-work-on-github/opening-an-issue-from-code のように issue 作成を試そうとすると、 permalink というパラメーターがつくようなので、同様につければ良さそうかと思ったのですが、
https://help.github.com/en/github/managing-your-work-on-github/about-automation-for-issues-and-pull-requests-with-query-parameters
にはなかったので、 body に変更したコミットを積んでから pull request を作成しました。