Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Noriben will crash with "--pml" option #21

Closed
mnrkbys opened this issue Jul 9, 2018 · 3 comments
Closed

Noriben will crash with "--pml" option #21

mnrkbys opened this issue Jul 9, 2018 · 3 comments

Comments

@mnrkbys
Copy link

mnrkbys commented Jul 9, 2018

I found a issue of Version 1.8.2.
Noriben will crash with the following message, when I specify "--pml".

Traceback (most recent call last):
File "Noriben.py", line 1488, in
main()
File "Noriben.py", line 1365, in main
with open(timeline_file, newline='', encoding='utf-8') as f:
FileNotFoundError: [Errno 2] No such file or directory: 'Noriben_06_Jul_18__12_31_034122_timeline.csv'

I found a bug around 1364 line.

        print('[*] Saving timeline to: {}'.format(timeline_file))
       # codecs.open(timeline_file, 'w', 'utf-8').write('\r\n'.join(timeline))
       with open(timeline_file, newline='', encoding='utf-8') as f:
           writer = csv.writer(f)
           writer.writerows(timeline)

I modified it such as following. It seems to work.

       print('[*] Saving timeline to: {}'.format(timeline_file))
       codecs.open(timeline_file, 'w', 'utf-8').write('\r\n'.join(timeline))
       # with open(timeline_file, newline='', encoding='utf-8') as f:
           # writer = csv.writer(f)
           # writer.writerows(timeline)
@Rurik
Copy link
Owner

Rurik commented Jul 9, 2018

Thank you, very much appreciated.

Can you confirm that you are on 1.8.2? I had run across that bug recently and put a tiny fix into 1.8.2 to fix it, here:

84b3c13#diff-bf0696a9ab04ef94dda0bdda3c4ffceb

The bug was that I left out the 'w' from the open() on line , which made the code try to read an existing file instead of create a new one. From your error message, it appears your code is 1.8.1?

@mnrkbys
Copy link
Author

mnrkbys commented Jul 10, 2018

I'm so sorry, I have misunderstood.
I was checking the version 1.8.1.
Please close this issue.

@Rurik
Copy link
Owner

Rurik commented Jul 10, 2018

Not a problem at all. It was a bad bug that I put in; I'm sorry for that. Thanks for reporting!

@Rurik Rurik closed this as completed Jul 10, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants