-
Notifications
You must be signed in to change notification settings - Fork 651
Conversation
cmake/configs/default.cmake
Outdated
@@ -347,3 +347,4 @@ hunter_config(zookeeper VERSION 3.4.9-p2) | |||
hunter_config(tacopie VERSION 2.4.0-h1) | |||
hunter_config(cpp_redis VERSION 3.5.0-h1) | |||
hunter_config(IF97 VERSION 2.1.2) | |||
hunter_config(inja VERSION 0.1.1) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's keep alphabetical order, put it after imshow
.
docs/packages/pkg/inja.rst
Outdated
==== | ||
|
||
- `Official <https://github.com/pantor/inja>`__ | ||
- `Hunterized <https://github.com/pantor/inja>`__ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not needed I guess since we are using official.
examples/inja/CMakeLists.txt
Outdated
project(download-inja) | ||
|
||
set(CMAKE_CXX_STANDARD 11) | ||
if(WIN32 AND MSVC AND MSVC_VERSION LESS 1900) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Add this check to hunter.cmake
and call hunter_report_broken_package
. This will report error before build starts:
hunter/cmake/projects/Boost/mpi/hunter.cmake
Lines 10 to 15 in 46986a7
if(NOT HUNTER_Boost_VERSION VERSION_LESS 1.56.0 AND MSVC) hunter_report_broken_package( "boost.mpi library failed to install even if b2 build exit with 0." "Use boost 1.55.0-patched-3" ) endif()
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The problem really originates from the JSON package. I'll remove it here and file a separate PR that fixes
hunter/cmake/projects/nlohmann_json/hunter.cmake
Lines 7 to 9 in 46986a7
include(hunter_pick_scheme) hunter_add_version(
examples/inja/CMakeLists.txt
Outdated
|
||
project(download-inja) | ||
|
||
set(CMAKE_CXX_STANDARD 11) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not needed here. C++ standard set in toolchain while CI testing.
find_package(inja CONFIG REQUIRED) | ||
|
||
add_executable(inja inja.cpp) | ||
target_link_libraries(inja inja::inja) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No description provided.