Skip to content
This repository has been archived by the owner on Apr 15, 2020. It is now read-only.

Add 'inja'package #1207

Merged
merged 8 commits into from Nov 17, 2017
Merged

Add 'inja'package #1207

merged 8 commits into from Nov 17, 2017

Conversation

jowr
Copy link
Contributor

@jowr jowr commented Nov 16, 2017

No description provided.

@@ -347,3 +347,4 @@ hunter_config(zookeeper VERSION 3.4.9-p2)
hunter_config(tacopie VERSION 2.4.0-h1)
hunter_config(cpp_redis VERSION 3.5.0-h1)
hunter_config(IF97 VERSION 2.1.2)
hunter_config(inja VERSION 0.1.1)
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's keep alphabetical order, put it after imshow.

====

- `Official <https://github.com/pantor/inja>`__
- `Hunterized <https://github.com/pantor/inja>`__
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not needed I guess since we are using official.

project(download-inja)

set(CMAKE_CXX_STANDARD 11)
if(WIN32 AND MSVC AND MSVC_VERSION LESS 1900)
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add this check to hunter.cmake and call hunter_report_broken_package. This will report error before build starts:

  • if(NOT HUNTER_Boost_VERSION VERSION_LESS 1.56.0 AND MSVC)
    hunter_report_broken_package(
    "boost.mpi library failed to install even if b2 build exit with 0."
    "Use boost 1.55.0-patched-3"
    )
    endif()

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The problem really originates from the JSON package. I'll remove it here and file a separate PR that fixes


project(download-inja)

set(CMAKE_CXX_STANDARD 11)
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not needed here. C++ standard set in toolchain while CI testing.

find_package(inja CONFIG REQUIRED)

add_executable(inja inja.cpp)
target_link_libraries(inja inja::inja)
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ruslo ruslo merged commit 6e9ecde into ruslo:master Nov 17, 2017
@ruslo
Copy link
Owner

ruslo commented Nov 17, 2017

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
2 participants