-
Notifications
You must be signed in to change notification settings - Fork 804
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Replace uses of unsafe
with safe alternatives
#1714
Conversation
these unsafe calls are there to avoid paying anohter bounds check (and for |
CodSpeed Performance ReportMerging #1714 will not alter performanceComparing Summary
|
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1714 +/- ##
==========================================
- Coverage 62.01% 62.01% -0.01%
==========================================
Files 24 24
Lines 2912 2917 +5
==========================================
+ Hits 1806 1809 +3
- Misses 1106 1108 +2 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
running the benchmarks again, this has no noticeable impact, so this will be ok
Some of the usages of
unsafe
in the codebase can now be replaced with safe functions from the rust standard library. This PR updates those to remove the unsafe blocksVerified that all of the tests are still passing.