You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
All the while working on this crate I have mistook the u5 type to be a general purpose integer type. To improve the API and help the next non-mathematician reading the code we could re-work the u5 type to make its purpose more explicit.
I think of u5 as a field element in GF32, definitely not as a standalone integer type. We could rename it if this is confusing.
Do we have Add and Mul implemented on this type, and do they respect field operations or "mod 32" operatons?
To be clearer: this crate has no use for integers mod 32, and I can't think of any crate that does.
All the while working on this crate I have mistook the
u5
type to be a general purpose integer type. To improve the API and help the next non-mathematician reading the code we could re-work theu5
type to make its purpose more explicit.ref: #89 (comment)
Consider fixing #80 at the same time.
The text was updated successfully, but these errors were encountered: