Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

crate labels go stale #2597

Closed
tcharding opened this issue Mar 14, 2024 · 6 comments
Closed

crate labels go stale #2597

tcharding opened this issue Mar 14, 2024 · 6 comments

Comments

@tcharding
Copy link
Member

We have a bot that adds crate labels to PRs but when a PR gets updated the bot does not check that the labels are valid still.

@tcharding
Copy link
Member Author

We fixed this a while back.

@Kixunil
Copy link
Collaborator

Kixunil commented Jun 30, 2024

I did this intentionally so that the bot doesn't remove other labels.

@tcharding
Copy link
Member Author

Oh you did? Perhaps I'm using the labels differently to you, I use them to later filter PRs, mainly to find things or to write the release notes. I found the stale labels hindered both use cases.

@Kixunil
Copy link
Collaborator

Kixunil commented Jul 1, 2024

OK, let's keep it and if it removing other labels gets too annoying we'll rethink.

@apoelstra
Copy link
Member

Can the bot "own" certain labels and only remove those?

@Kixunil
Copy link
Collaborator

Kixunil commented Jul 1, 2024

It couldn't last time I checked :(

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants