Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update rand dependency #328

Closed
survived opened this issue Sep 13, 2021 · 7 comments
Closed

Update rand dependency #328

survived opened this issue Sep 13, 2021 · 7 comments

Comments

@survived
Copy link

secp256k1 depends on rand ^0.6 which's not up-to-date, latest rand is v0.8.4 now. That would be nice to update it to ^0.8

@thomaseizinger
Copy link
Contributor

I think we can at least go to 0.7 once MSRV is upped to 1.36 which should happen soon!

@elichai
Copy link
Member

elichai commented Sep 13, 2021

@thomaseizinger Rust 1.36 allows us to use 0.8.

I'll open today/tomorrow a PR updating this library to 1.36 and rust 2018, but @survived because this is an OSS project and it's a big change it might take some time before it will be merged and released.

@apoelstra
Copy link
Member

I'd like to get the Taproot release(s) out for all these crates and then do a 2018 release after that.

So, yes, "a while", but it hopefully won't be super far in the future :)

@elichai
Copy link
Member

elichai commented Sep 15, 2021

CC #331

@0ndorio
Copy link

0ndorio commented Oct 6, 2021

@elichai Thanks for your work. @apoelstra Is #331 currently blocked by any major issues or just through time concerns? Is there anything I could do to speed up the review/merge process?

@apoelstra
Copy link
Member

@0ndorio just time concerns -- we want to merge all the taproot stuff first, then cut a release, then we can do 2018 stuff.

@tcharding
Copy link
Member

rand has been updated, this can be closed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

6 participants