-
Notifications
You must be signed in to change notification settings - Fork 66
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Determine rustc version and add it to the report #81
base: master
Are you sure you want to change the base?
Conversation
Cargo also sets the |
Did not know that! I'll update that right now. |
@bjorn3 - getting this issue:
I'm on nightly. |
You should use |
@bjorn3 - All done. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM apart from one nit. Do note that I am not a member of this org, so you will have to wait on someone who is to review and merge.
Should I rebase this PR, or are the maintainers fine with 7 (maybe more later if there's more review) commits? |
It probably won't hurt to squash. No idea what the maintainers prefer though. |
I'll probably have time to rebase this on Sunday. |
This is a 🙋 feature.
Checklist
Context
Fixes #31
Semver Changes
Major release - it changes the
Report
struct. I don't think 2.0 is released yet, so that would fit perfectly!I have very little experience contributing to Rust crates, so if I made any mistakes, let me know!