Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added benches #3

Merged
merged 8 commits into from
Aug 15, 2021
Merged

added benches #3

merged 8 commits into from
Aug 15, 2021

Conversation

makoConstruct
Copy link
Contributor

resolves #2

@vadixidav
Copy link
Member

vadixidav commented Aug 13, 2021

@makoConstruct Two things:

  1. Take care of the issues CI identified, it should be fairly simple
  2. If you know how to, or can figure it out, please add a GitHub Action to add the benchmarks to CI (cargo bench) using the existing template already there

If you are done with this or want me to do either of these things, just let me know and I will follow up when I have time.

src/lib.rs Outdated Show resolved Hide resolved
src/lib.rs Outdated
@@ -1,4 +1,5 @@
#![no_std]
#![feature(const_if_match)]
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oops, that's not even being used. I brought it in to do Vec's thing of starting with an allocation of a sensible initial capacity, but realized it doesn't really translate directly to us, because the allocation has to include the header, and I'm not sure how to calculate that. (I'll think about it)

@vadixidav
Copy link
Member

I am going to merge this. The documentation, benchmarks, etc are helpful. If you have additional performance tweaks, please open those as new PRs.

@vadixidav vadixidav merged commit a05e288 into rust-cv:main Aug 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add benchmarks against std vec
2 participants