Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Setting a pixel out of bounds crashes the driver #19

Closed
jamwaffles opened this issue Mar 23, 2018 · 0 comments
Closed

Setting a pixel out of bounds crashes the driver #19

jamwaffles opened this issue Mar 23, 2018 · 0 comments
Assignees
@jamwaffles
Labels
bug Something isn't working
Milestone
Release 0.1

Comments

@jamwaffles
Copy link
Collaborator

The display buffer has a fixed length. There should be a guard that just does a noop if the pixel coordinates are out of bounds. I think this is better than returning a Result::Err because it allows the user more freedom in what they (try and) show on the display.
@jamwaffles jamwaffles added the bug Something isn't working label Mar 23, 2018
@jamwaffles jamwaffles added this to the Release 0.1 milestone Mar 23, 2018
@jamwaffles jamwaffles self-assigned this Mar 23, 2018
@jamwaffles jamwaffles mentioned this issue Mar 23, 2018
Closed
jamwaffles added a commit that referenced this issue Mar 23, 2018
@jamwaffles
Add guard around out of bounds pixel set
4b9967c 
Closeses #19
@jamwaffles jamwaffles mentioned this issue Mar 23, 2018
Merged
jamwaffles added a commit that referenced this issue Mar 27, 2018
@jamwaffles
Add guard around out of bounds pixel set
525daaa 
Closeses #19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jamwaffles jamwaffles

Labels
bug Something isn't working
Projects
None yet
Milestone
Release 0.1
Development

No branches or pull requests
1 participant
@jamwaffles