Add pad_tail_using and interleave_shortest adaptors.
#31
Conversation
|
|
||
| #[inline] | ||
| fn next(&mut self) -> Option<I::Item> { | ||
| match self.phase { |
There was a problem hiding this comment.
I think we can shorten this with phase = !phase here.
There was a problem hiding this comment.
You can, but I really didn't want to do that because then you need to match on !phase, which is weird. If you want to cut the repetition out, I suppose I can bind the result of the match to a local r, then flip phase after the match, then return r... but the code would be the same length anyway.
I dunno; might just be my penchant for state machines. :P
|
Looking forward to these prs from grabbag! Don't you think a name like pad_to or pad_to_length would be better? |
|
@bluss From the commit message:
I hadn't considered |
|
That's a good point. I didn't look at the commit msg, away from my computer today.. What about simply pad_using? |
I've chosen the `using` suffix as I believe possibly useful variants of this would better suit the alternatives: * `to`: best for a variant that just repeats the final element of the base sequence. * `from`/`with`: sounds like it should take another iterator as input; *i.e.* a kind of `chain`+`take` combination.
|
Ok, I think that did it. Not sure if you get a notification for that or not. |
|
Leaving a message here is the best yeah, no notification on just pushes. |
|
Looks fine. I'm a stubborn mind, so I wanted to ask. Is it ok if I merge this? I'm going to change the name to what I prefer, is that ok? |
|
Yeah, if you want to change the names, go ahead; it's your prerogative, after all. Disclaimer: I'm not going to be held responsible for naming conflicts with future hypothetical |
pad_tail_usingensures an iterator has some minimum number of elements, with a closure used to fill in the missing ones.interleave_shortestdoes exactly what it says on the tin.Both are adapted from
grabbag.