Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Should we release 0.10.4? #640

Merged
merged 3 commits into from
Sep 12, 2022
Merged

Should we release 0.10.4? #640

merged 3 commits into from
Sep 12, 2022

Conversation

phimuemue
Copy link
Member

@phimuemue phimuemue commented Sep 4, 2022

Hi @jswrenn: I thought about publishing v0.10.4. It's not that much, but I think it's good that the new functions get exposure to real use cases.

@jswrenn
Copy link
Member

jswrenn commented Sep 6, 2022

Sounds good! I'll merge this, and publish a release (probably tomorrow morning).

Sorry for my absence; I'm hoping to start being more active again. What's the status of the rustfmt/clippy PRs? Are they still in-progress, or stalled? Should I avoid merging another PRs until those merge?

@phimuemue
Copy link
Member Author

Sorry for my absence; I'm hoping to start being more active again.

No worries.

What's the status of the rustfmt/clippy PRs? Are they still in-progress, or stalled? Should I avoid merging another PRs until those merge?

I think #618 has some very good parts in it, but I did not yet get around to merging... I'll see when I can do them (feel free to do it before me if you want). I think it would be ok to postpone #619 at least until #618 is settled.

From my point of view, you can merge the PRs you consider appropriate. And as a last resort (read: if we introduce conflicts in #618) I think @hellow554 did a good enough job so that merging should not be too hard.

@jswrenn jswrenn merged commit 8d362f2 into rust-itertools:master Sep 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants