Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Derive Ord when possible #884

Closed
fitzgen opened this issue Aug 1, 2017 · 2 comments
Closed

Derive Ord when possible #884

fitzgen opened this issue Aug 1, 2017 · 2 comments
Labels
A-derive C-assigned E-less-easy enhancement help wanted

Comments

@fitzgen
Copy link
Member

fitzgen commented Aug 1, 2017

Depends on #882.

Once we know it is PartialOrd, I think this pretty much comes down to whether the type contains a float or not.
This was referenced Aug 1, 2017
Open
Open
@pepyakin
Copy link
Contributor

@highfive: assign me

@highfive
Copy link

Hey @pepyakin! Thanks for your interest in working on this issue. It's now assigned to you!

@pepyakin pepyakin mentioned this issue Sep 19, 2017
Merged
bors-servo pushed a commit that referenced this issue Sep 19, 2017
Auto merge of #1003 - pepyakin:derive-ord-when-possible, r=fitzgen
de0180e 
Derive ord when possible

Fixes #884

r? @fitzgen
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
A-derive C-assigned E-less-easy enhancement help wanted
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@fitzgen @pepyakin @highfive