Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build.rs: canonicalize OUT_DIR #606

Closed
wants to merge 2 commits into from

Conversation

TheLortex
Copy link

Hi, I discovered a build problem when building this crate with the Bazel build system for the Android platform.

This warning occurs:

Build Script Warning: clang: error: no such file or directory: 'external/crate_index__backtrace-0.3.69/src/android-api.c'
Build Script Warning: clang: error: no input files

The problem is due to the fact that OUT_DIR is a relative path, and it looks like cc::Build:: ... .try_expand() expects an absolute path. Maybe because it's running inside a temporary dir ? I didn't dig enough to know.

I can confirm that canonicalizing the OUT_DIR fixes my problem.

build.rs Outdated Show resolved Hide resolved
@workingjubilee
Copy link
Member

@TheLortex I do not think we should modify this code unless rust-lang/rust#120593 fails to go through in a reasonable timeframe (say, next few weeks), because I would prefer the next modification to this file to not be an error correction but a deletion.

@TheLortex TheLortex closed this Jun 2, 2024
@TheLortex TheLortex deleted the 0.3.71+fx branch July 3, 2024 09:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants